Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ccache use on github workflows #1243

Merged
merged 8 commits into from
May 27, 2024
Merged

Improve ccache use on github workflows #1243

merged 8 commits into from
May 27, 2024

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented May 18, 2024

This PR:

  • fixes ccache invalidation due to different runner host names
  • increases ccache size for windows which I think is causing issues with invalidation
  • adds a cron job so that every sunday morning all ccache entries are cleared and new ones regenerated
  • Updates the pr filename for consistency with the workflow trigger
  • Update the merge_group workflow so we can try it again

@sethrj sethrj added the documentation Documentation, examples, tests, and CI label May 18, 2024
@sethrj sethrj requested a review from pcanal May 18, 2024 15:10
pcanal
pcanal reviewed May 20, 2024
View reviewed changes
.github/workflows/clear-cache.yml

jobs:
clear-cache:
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it run on all the platform with CCache? (I.e. eg Windows?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. All it's doing is making GitHub calls; the cache itself is platform agnostic.

@sethrj sethrj requested a review from pcanal May 22, 2024 09:09
@sethrj
Copy link
Member Author

sethrj commented May 22, 2024

Ping @pcanal

1 similar comment
@sethrj
Copy link
Member Author

sethrj commented May 24, 2024

Ping @pcanal

@sethrj sethrj enabled auto-merge (squash) May 27, 2024 12:20
@sethrj sethrj disabled auto-merge May 27, 2024 12:21
@sethrj sethrj merged commit 3d6f3c5 into celeritas-project:develop May 27, 2024
8 of 9 checks passed
@sethrj sethrj deleted the ci-ccache branch May 27, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcanal pcanal Awaiting requested review from pcanal

Assignees
No one assigned
Labels
documentation Documentation, examples, tests, and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sethrj @pcanal